Refactor metrics domainstats #11601

machadovilaca · 2024-03-26T13:18:26Z

What this PR does

Before this PR:

domainstats were not refactor accordingly to kubevirt/community#219

After this PR:

domainstats are refactored

Fixes #

jira-ticket: https://issues.redhat.com/browse/CNV-38133

Why we need it and why it was done in this way

The following tradeoffs were made:

The following alternatives were considered:

Links to places where the discussion took place:

Special notes for your reviewer

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Design: A design document was considered and is present (link) or not required
PR: The PR description is expressive enough and will help future contributors
Code: Write code that humans can understand and Keep it simple
Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
Upgrade: Impact of this change on upgrade flows was considered and addressed if required
Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
Community: Announcement to kubevirt-dev was considered

Release note

none

machadovilaca · 2024-04-16T09:45:19Z

/retest

machadovilaca · 2024-04-16T15:27:53Z

/retest

machadovilaca · 2024-04-17T10:00:11Z

tests/monitoring/component_monitoring.go

@@ -236,7 +236,7 @@ var _ = Describe("[Serial][sig-monitoring]Component Monitoring", Serial, decorat
 			}, 5*time.Minute, 500*time.Millisecond).Should(Succeed())
 		})

-		It("VirtHandlerRESTErrorsBurst and VirtHandlerRESTErrorsHigh should be triggered when requests to virt-handler are failing", func() {
+		PIt("VirtHandlerRESTErrorsBurst and VirtHandlerRESTErrorsHigh should be triggered when requests to virt-handler are failing", func() {


I found the E2E tests for virt-handler were having the same flakiness as 415964c#diff-5973bd8e1862c32cabfb41df6b9f6ebd8c81eb221b43965d12779f2476514579R224

I also marked it as pending to check them later together

ref: 0c086a0

@machadovilaca Does the flakiness related to this PR changes?

yeah, not really, different PR?

Yes, it's better to split so we can track these changes better.

assafad · 2024-04-22T10:32:29Z

/lgtm

machadovilaca · 2024-05-13T01:44:13Z

/retest pull-kubevirt-unit-test

kubevirt-bot · 2024-05-13T01:44:17Z

@machadovilaca: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

/test pull-kubevirt-apidocs
/test pull-kubevirt-build
/test pull-kubevirt-build-arm64
/test pull-kubevirt-check-unassigned-tests
/test pull-kubevirt-client-python
/test pull-kubevirt-code-lint
/test pull-kubevirt-e2e-k8s-1.28-sig-compute
/test pull-kubevirt-e2e-k8s-1.28-sig-network
/test pull-kubevirt-e2e-k8s-1.28-sig-operator
/test pull-kubevirt-e2e-k8s-1.28-sig-storage
/test pull-kubevirt-e2e-k8s-1.29-sig-compute
/test pull-kubevirt-e2e-k8s-1.29-sig-monitoring
/test pull-kubevirt-e2e-k8s-1.29-sig-network
/test pull-kubevirt-e2e-k8s-1.29-sig-operator
/test pull-kubevirt-e2e-k8s-1.29-sig-performance
/test pull-kubevirt-e2e-k8s-1.29-sig-storage
/test pull-kubevirt-e2e-k8s-1.30-ipv6-sig-network
/test pull-kubevirt-e2e-k8s-1.30-sig-compute
/test pull-kubevirt-e2e-k8s-1.30-sig-compute-migrations
/test pull-kubevirt-e2e-k8s-1.30-sig-compute-serial
/test pull-kubevirt-e2e-k8s-1.30-sig-network
/test pull-kubevirt-e2e-k8s-1.30-sig-operator
/test pull-kubevirt-e2e-k8s-1.30-sig-storage
/test pull-kubevirt-e2e-kind-sriov
/test pull-kubevirt-e2e-windows2016
/test pull-kubevirt-fossa
/test pull-kubevirt-generate
/test pull-kubevirt-manifests
/test pull-kubevirt-prom-rules-verify
/test pull-kubevirt-unit-test
/test pull-kubevirt-verify-go-mod

The following commands are available to trigger optional jobs:

/test build-kubevirt-builder
/test pull-kubevirt-build-s390x
/test pull-kubevirt-check-tests-for-flakes
/test pull-kubevirt-conformance-arm64
/test pull-kubevirt-e2e-arm64
/test pull-kubevirt-e2e-k8s-1.29-sig-compute-realtime
/test pull-kubevirt-e2e-k8s-1.29-sig-compute-root
/test pull-kubevirt-e2e-k8s-1.29-sig-network-multus-v4
/test pull-kubevirt-e2e-k8s-1.29-sig-storage-root
/test pull-kubevirt-e2e-k8s-1.29-single-node
/test pull-kubevirt-e2e-k8s-1.29-swap-enabled
/test pull-kubevirt-e2e-kind-1.27-vgpu
/test pull-kubevirt-gosec
/test pull-kubevirt-goveralls
/test pull-kubevirt-metrics-lint
/test pull-kubevirt-unit-test-arm64
/test pull-kubevirt-verify-rpms

Use /test all to run the following jobs that were automatically triggered:

pull-kubevirt-apidocs
pull-kubevirt-build
pull-kubevirt-build-arm64
pull-kubevirt-check-tests-for-flakes
pull-kubevirt-check-unassigned-tests
pull-kubevirt-client-python
pull-kubevirt-code-lint
pull-kubevirt-conformance-arm64
pull-kubevirt-e2e-arm64
pull-kubevirt-e2e-k8s-1.29-sig-monitoring
pull-kubevirt-e2e-k8s-1.29-sig-performance
pull-kubevirt-e2e-k8s-1.30-sig-compute
pull-kubevirt-e2e-k8s-1.30-sig-compute-migrations
pull-kubevirt-e2e-k8s-1.30-sig-compute-serial
pull-kubevirt-e2e-k8s-1.30-sig-network
pull-kubevirt-e2e-k8s-1.30-sig-operator
pull-kubevirt-e2e-k8s-1.30-sig-storage
pull-kubevirt-fossa
pull-kubevirt-generate
pull-kubevirt-goveralls
pull-kubevirt-manifests
pull-kubevirt-metrics-lint
pull-kubevirt-prom-rules-verify
pull-kubevirt-unit-test
pull-kubevirt-unit-test-arm64
pull-kubevirt-verify-go-mod

In response to this:

/retest pull-kubevirt-unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

machadovilaca · 2024-05-13T01:44:53Z

/test pull-kubevirt-unit-test

assafad · 2024-05-13T07:06:50Z

/lgtm

enp0s3

@machadovilaca Thank you for the PR! can you please mention in the PR description all the refactor changes you are about to do? it seems that you have commits unrelated to domainstats refactoring

machadovilaca · 2024-05-13T13:54:18Z

@machadovilaca Thank you for the PR! can you please mention in the PR description all the refactor changes you are about to do? it seems that you have commits unrelated to domainstats refactoring

@enp0s3 only https://github.com/kubevirt/kubevirt/pull/11601/files#r1598518754 really, the virt-handler version metric and handler were meshed with the domainstats

enp0s3 · 2024-05-20T10:29:51Z

/approve
/hold
@machadovilaca Please open a different PR for the test quarantine, feel free to unhold then.

kubevirt-bot · 2024-05-20T10:30:01Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enp0s3, sradco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [enp0s3]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kubevirt-commenter-bot · 2024-05-20T10:30:03Z

Required labels detected, running phase 2 presubmits:
/test pull-kubevirt-e2e-windows2016
/test pull-kubevirt-e2e-kind-sriov
/test pull-kubevirt-e2e-k8s-1.30-ipv6-sig-network
/test pull-kubevirt-e2e-k8s-1.28-sig-network
/test pull-kubevirt-e2e-k8s-1.28-sig-storage
/test pull-kubevirt-e2e-k8s-1.28-sig-compute
/test pull-kubevirt-e2e-k8s-1.28-sig-operator
/test pull-kubevirt-e2e-k8s-1.29-sig-network
/test pull-kubevirt-e2e-k8s-1.29-sig-storage
/test pull-kubevirt-e2e-k8s-1.29-sig-compute
/test pull-kubevirt-e2e-k8s-1.29-sig-operator

machadovilaca · 2024-05-20T10:57:38Z

waiting #11945

…andler Signed-off-by: machadovilaca <machadovilaca@gmail.com>

Signed-off-by: machadovilaca <machadovilaca@gmail.com>

machadovilaca · 2024-05-20T13:09:49Z

waiting #11945

merged
/unhold

assafad · 2024-05-20T13:32:15Z

/lgtm

kubevirt-commenter-bot · 2024-05-20T13:32:20Z

Required labels detected, running phase 2 presubmits:
/test pull-kubevirt-e2e-windows2016
/test pull-kubevirt-e2e-kind-sriov
/test pull-kubevirt-e2e-k8s-1.30-ipv6-sig-network
/test pull-kubevirt-e2e-k8s-1.28-sig-network
/test pull-kubevirt-e2e-k8s-1.28-sig-storage
/test pull-kubevirt-e2e-k8s-1.28-sig-compute
/test pull-kubevirt-e2e-k8s-1.28-sig-operator
/test pull-kubevirt-e2e-k8s-1.29-sig-network
/test pull-kubevirt-e2e-k8s-1.29-sig-storage
/test pull-kubevirt-e2e-k8s-1.29-sig-compute
/test pull-kubevirt-e2e-k8s-1.29-sig-operator

kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XXL labels Mar 26, 2024

kubevirt-bot requested review from fossedihelm, rthallisey and xpivarc March 26, 2024 13:18

kubevirt-bot added area/monitoring kind/build-change Categorizes PRs as related to changing build files of virt-* components sig/buildsystem Denotes an issue or PR that relates to changes in the build system. sig/scale labels Mar 26, 2024

avlitman mentioned this pull request Apr 8, 2024

Refactor metrics doc generator #11467

Closed

kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 9, 2024

machadovilaca force-pushed the refactor-metrics-domainstats branch from ba6dae9 to 4b5a40b Compare April 11, 2024 14:09

kubevirt-bot added sig/observability Denotes an issue or PR that relates to observability. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 11, 2024

machadovilaca force-pushed the refactor-metrics-domainstats branch 4 times, most recently from 8180122 to 8bd0228 Compare April 15, 2024 16:06

machadovilaca force-pushed the refactor-metrics-domainstats branch 2 times, most recently from 6b0a987 to 87538ba Compare April 16, 2024 14:49

machadovilaca force-pushed the refactor-metrics-domainstats branch from 8f1c2f7 to 415964c Compare April 17, 2024 09:42

machadovilaca commented Apr 17, 2024

View reviewed changes

machadovilaca force-pushed the refactor-metrics-domainstats branch 2 times, most recently from c1b865b to 86cad03 Compare April 22, 2024 09:54

kubevirt-bot assigned assafad Apr 22, 2024

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2024

kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label May 9, 2024

machadovilaca force-pushed the refactor-metrics-domainstats branch 2 times, most recently from e917b10 to 26f700a Compare May 13, 2024 01:30

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2024

enp0s3 reviewed May 13, 2024

View reviewed changes

kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 20, 2024

kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2024

machadovilaca force-pushed the refactor-metrics-domainstats branch from 26f700a to c48c44c Compare May 20, 2024 10:57

kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label May 20, 2024

machadovilaca added 5 commits May 20, 2024 14:08

Move virt-handler prometheus handler to pkg/monitoring/metrics/virt-h…

8b83a1e

…andler Signed-off-by: machadovilaca <machadovilaca@gmail.com>

Move virt-handler version metric

f42232c

Signed-off-by: machadovilaca <machadovilaca@gmail.com>

Refactor domainstats metrics

bdc3f9a

Signed-off-by: machadovilaca <machadovilaca@gmail.com>

Refactor domainstats collector

68afcdc

Signed-off-by: machadovilaca <machadovilaca@gmail.com>

Update metrics documentation generator

9a1a931

Signed-off-by: machadovilaca <machadovilaca@gmail.com>

machadovilaca force-pushed the refactor-metrics-domainstats branch from c48c44c to 9a1a931 Compare May 20, 2024 13:08

kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 20, 2024

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2024

kubevirt-bot merged commit 666d4ff into kubevirt:main May 20, 2024
40 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor metrics domainstats #11601

Refactor metrics domainstats #11601

machadovilaca commented Mar 26, 2024 •

edited

machadovilaca commented Apr 16, 2024

machadovilaca commented Apr 16, 2024

machadovilaca Apr 17, 2024 •

edited

enp0s3 May 13, 2024

machadovilaca May 13, 2024

sradco May 13, 2024

assafad commented Apr 22, 2024

machadovilaca commented May 13, 2024

kubevirt-bot commented May 13, 2024

machadovilaca commented May 13, 2024

assafad commented May 13, 2024

enp0s3 left a comment

machadovilaca commented May 13, 2024

enp0s3 commented May 20, 2024

kubevirt-bot commented May 20, 2024

kubevirt-commenter-bot commented May 20, 2024

machadovilaca commented May 20, 2024

machadovilaca commented May 20, 2024

assafad commented May 20, 2024

kubevirt-commenter-bot commented May 20, 2024

Refactor metrics domainstats #11601

Refactor metrics domainstats #11601

Conversation

machadovilaca commented Mar 26, 2024 • edited

What this PR does

Why we need it and why it was done in this way

Special notes for your reviewer

Checklist

Release note

machadovilaca commented Apr 16, 2024

machadovilaca commented Apr 16, 2024

machadovilaca Apr 17, 2024 • edited

Choose a reason for hiding this comment

enp0s3 May 13, 2024

Choose a reason for hiding this comment

machadovilaca May 13, 2024

Choose a reason for hiding this comment

sradco May 13, 2024

Choose a reason for hiding this comment

assafad commented Apr 22, 2024

machadovilaca commented May 13, 2024

kubevirt-bot commented May 13, 2024

machadovilaca commented May 13, 2024

assafad commented May 13, 2024

enp0s3 left a comment

Choose a reason for hiding this comment

machadovilaca commented May 13, 2024

enp0s3 commented May 20, 2024

kubevirt-bot commented May 20, 2024

kubevirt-commenter-bot commented May 20, 2024

machadovilaca commented May 20, 2024

machadovilaca commented May 20, 2024

assafad commented May 20, 2024

kubevirt-commenter-bot commented May 20, 2024

machadovilaca commented Mar 26, 2024 •

edited

machadovilaca Apr 17, 2024 •

edited